STH archive not working?

having trouble with an archived file? post in here!
Post Reply
tom_seddon
Posts: 889
Joined: Tue Aug 30, 2005 12:42 am
Contact:

STH archive not working?

Post by tom_seddon »

Just went to look for something on the stairwaytohell.com archive, which I'm certain was working last I tried it (within the last month or so), and I just get blank pages. For example: http://www.stairwaytohell.com/bbc/archi ... ilter=.zip

This also affects JSBeeb's "Load from STH" option.

I know the STH archive isn't being updated any more - but is it still supposed to work? Or have I just got unlucky with some transient and/or local issue?

--Tom
User avatar
sweh
Posts: 3313
Joined: Sat Mar 10, 2012 12:05 pm
Location: 07410 New Jersey
Contact:

Re: STH archive not working?

Post by sweh »

The archive seems to be there ( http://www.stairwaytohell.com/bbc/archive/diskimages/ ) but the "reclist.php" page is return 500 errors ("server error").
Rgds
Stephen
User avatar
richardtoohey
Posts: 4075
Joined: Thu Dec 29, 2011 5:13 am
Location: Tauranga, New Zealand
Contact:

Re: STH archive not working?

Post by richardtoohey »

Upgrade to PHP 7.x needs attention? :-k (But no HTTP headers so can't see PHP version anyway.)

Or could be something completely different. :D
User avatar
Arcadian
Site Admin
Posts: 4220
Joined: Fri Nov 24, 2000 12:16 pm
Contact:

Re: STH archive not working?

Post by Arcadian »

Hi, this has happened before (where php upgrades have broken the indexer scripts, which were written many years ago!).

If any php wizards can identify anything in the attached /render.php and reclist/reclister scripts that may be causing the problem, please let me know.

If FTP access is needed, again - let me know.

Thanks.
Attachments
render.zip
(712 Bytes) Downloaded 79 times
reclister.zip
(1.1 KiB) Downloaded 76 times
reclist.zip
(1.12 KiB) Downloaded 83 times
Please subscribe to the ABug YouTube channel!
User avatar
richardtoohey
Posts: 4075
Joined: Thu Dec 29, 2011 5:13 am
Location: Tauranga, New Zealand
Contact:

Re: STH archive not working?

Post by richardtoohey »

Would be good to see the logs if you can get those.

Assuming we're talking upgrade from PHP 5.x to 7.x? Or is it something else?

In render.php - split is no longer available:

list($include, $buffer) = split("\"?'? ?-->", $buffer, 2);

It appears at least 3 times in render.php.

See http://php.net/manual/en/function.split.php

I'll have a look at the others too ...
Last edited by richardtoohey on Sun Dec 23, 2018 1:55 am, edited 1 time in total.
User avatar
richardtoohey
Posts: 4075
Joined: Thu Dec 29, 2011 5:13 am
Location: Tauranga, New Zealand
Contact:

Re: STH archive not working?

Post by richardtoohey »

render.php also uses the deprecated spliti function:

http://php.net/manual/en/function.spliti.php

Looks like the other two files pull in render.php, so that will cause both of them to stop working until it is fixed.

Can't spot anything immediately obvious in the other two ... but that's where the server error logs will be a great help.

(Again this is all assuming we are talking about a move from PHP 5.x to 7.x).
User avatar
richardtoohey
Posts: 4075
Joined: Thu Dec 29, 2011 5:13 am
Location: Tauranga, New Zealand
Contact:

Re: STH archive not working?

Post by richardtoohey »

Attached is a simple replacement of split / spliti with preg_split versions. Might help a bit. But might need tweaking and there may be more to do.

Don't think it will make anything worse - if they don't work, you'll still end up with the white screen.

Backup render.php and then copy & rename this new_render.php to render.php and see if it goes any further forward.

(Just spent the last few weeks moving from PHP 5.6 to PHP 7.2 on a few servers).
Attachments
new_render.zip
(827 Bytes) Downloaded 83 times
Last edited by richardtoohey on Sun Dec 23, 2018 2:20 am, edited 1 time in total.
User avatar
Arcadian
Site Admin
Posts: 4220
Joined: Fri Nov 24, 2000 12:16 pm
Contact:

Re: STH archive not working?

Post by Arcadian »

Thanks Richard, I've only just got round to swapping in your updated render.php file and it appears to have done the trick! :)
Please subscribe to the ABug YouTube channel!
User avatar
lurkio
Posts: 4351
Joined: Wed Apr 10, 2013 12:30 am
Location: Doomawangara
Contact:

Re: STH archive not working?

Post by lurkio »

Arcadian wrote: Sat Dec 29, 2018 3:17 pm Thanks Richard, I've only just got round to swapping in your updated render.php file and it appears to have done the trick! :)
Yay! Well done, both!

=D> =D> =D>

Btw, do we know what's happening with the Retro Software site?

:?:
User avatar
richardtoohey
Posts: 4075
Joined: Thu Dec 29, 2011 5:13 am
Location: Tauranga, New Zealand
Contact:

Re: STH archive not working?

Post by richardtoohey »

Was expecting a few more glitches so will wait and see before counting chickens ... [-o<

I've been talking to Simon and he's talking to Dave re. the Retro Software site so we'll see (guessing it needs a newer version of MediaWiki that is PHP 7.x friendly, but that's a wild guess!)
Post Reply

Return to “archive issues”